Move to a helper and fix tests #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravtiwari
referenced
this pull request
Aug 13, 2017
Then Webpacker.dev_server.running? will return false in testing even though the dev server is running, so on-demand testing will work as expected.
|
How about creating a base test class instead? # webpacker_test_helper.rb
class Webpacker::Test < Minitest::Test
private
def reloaded_config
Webpacker.instance.instance_variable_set(:@config, nil)
Webpacker.config
end
def with_node_env(env)
original = ENV["NODE_ENV"]
ENV["NODE_ENV"] = env
yield
ensure
ENV["NODE_ENV"] = original
end
end |
|
@javan Even better 👍 💯 Pushed an update |
javan
approved these changes
Aug 15, 2017
gauravtiwari
added a commit
that referenced
this pull request
Aug 15, 2017
* master: Move to a helper and fix tests (#648) Spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the reloaded_config method to a helper and use that for dev_server_test as well